ports
/
contrib
3
3
Fork 2
Code Issues Pull Requests Activity

wxgtk3 build failure #10

New Issue
Closed
opened 2024-04-29 20:28:12 +02:00 by tb · 3 comments
tb commented 2024-04-29 20:28:12 +02:00
Owner
Copy Link

https://sprunge.us/uUwORR

https://sprunge.us/uUwORR
farkuhar was assigned by tb 2024-04-29 20:28:12 +02:00
farkuhar commented 2024-04-30 21:49:30 +02:00
Member
Copy Link

Upstream devs committed a fix five months ago: 5a7fba5639
I could have just used their fix as-is, but enclosing the offending code with another #ifdef and #endif pair appears to have the same effect.

Upstream devs committed a fix five months ago: https://github.com/vadz/wxWidgets/commit/5a7fba56390b319de2b7ec2f8c244d6144c5ebea I could have just used their fix as-is, but enclosing the offending code with another #ifdef and #endif pair appears to have the same effect.
farkuhar commented 2024-05-01 18:01:45 +02:00
Member
Copy Link

Rather than take a chance with the insertion of another #ifdef and #endif pair (which might have unforeseen side-effects that aren't yet showing up in my tests), I went with the fix that upstream devs consider cleanest. Thanks for reporting!

Rather than take a chance with the insertion of another #ifdef and #endif pair (which might have unforeseen side-effects that aren't yet showing up in my tests), I went with the fix that upstream devs consider cleanest. Thanks for reporting!
tb commented 2024-05-01 18:44:15 +02:00
Author
Owner
Copy Link

Can confirm that it builds now, thanks!

Can confirm that it builds now, thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
3.7
3.8
3.6
3.5
3.4
3.3
3.2
3.1
3.0
2.8
2.7
2.6
2.5
2.4
2.3
2.2
master
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
farkuhar
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ports/contrib#10
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?