ports/opt
4
3
Fork 1
Code Issues 1 Pull Requests Activity

pkg-get: dependency outside core #16

New Issue
Closed
opened 2025-01-04 16:31:34 +01:00 by farkuhar · 4 comments
farkuhar commented 2025-01-04 16:31:34 +01:00
Member
Copy Link

As reported by ppetrov^, pkg-get 0.4.7 has a hidden runtime dependency on wget. Distro policy allowed such a dependency to be omitted when wget was a core port, but now wget has been moved to opt, requiring some action to prevent runtime errors. Two possible solutions:

  • Keep the 0.4.7 code as-is, but insert "Depends on: wget" into the Pkgfile header.
  • Merge some of the changes from farkuhar's forked repo, especially the replacement of wget commands with their curl counterparts. The scripts as of commit 3224209ff77c8bae095c4fd11430b5b8076d039a have been employed in a test environment for at least twelve months, and the scripts at the head of the master branch were tested again today with the latest set of updated packages.
As reported by ppetrov^, pkg-get 0.4.7 has a hidden runtime dependency on wget. Distro policy allowed such a dependency to be omitted when wget was a core port, but now wget has been moved to opt, requiring some action to prevent runtime errors. Two possible solutions: - Keep the 0.4.7 code as-is, but insert "Depends on: wget" into the Pkgfile header. - Merge some of the changes from farkuhar's forked repo, especially the replacement of wget commands with their curl counterparts. The scripts as of commit 3224209ff77c8bae095c4fd11430b5b8076d039a have been employed in a test environment for at least twelve months, and the scripts at the head of the master branch were tested again today with the latest set of updated packages.
tb commented 2025-01-05 23:51:18 +01:00
Owner
Copy Link

I added wget to get this fixed right now but I don't use/take much interest in pkg-get myself.
Lookin at your fork you did more work on it than just this single change. If it works well I don't see any reason why this can't be switched.
@jaeger @jue Do you have any thoughts about it?

I added wget to get this fixed right now but I don't use/take much interest in pkg-get myself. Lookin at your fork you did more work on it than just this single change. If it works well I don't see any reason why this can't be switched. @jaeger @jue Do you have any thoughts about it?
jue commented 2025-01-06 11:54:36 +01:00
Owner
Copy Link

No objections to switch to farkuhar's fork of pkg-get. I use pkg-get for some older systems, so it's in my interest to keep or better improve it.

No objections to switch to farkuhar's fork of pkg-get. I use pkg-get for some older systems, so it's in my interest to keep or better improve it.
jaeger commented 2025-01-06 18:20:36 +01:00
Owner
Copy Link

No preference here, it's not something I use.

No preference here, it's not something I use.
tb commented 2025-01-10 18:46:36 +01:00
Owner
Copy Link

@farkuhar Congratulations, I have added write access to tools/pkg-get for you, feel free to update opt/pkg-get, and ideally opt/pkg-get-bashcompletion as well.

@farkuhar Congratulations, I have added write access to [tools/pkg-get](https://git.crux.nu/tools/pkg-get) for you, feel free to update [opt/pkg-get](https://git.crux.nu/ports/opt/src/branch/3.7/pkg-get), and ideally [opt/pkg-get-bashcompletion](https://git.crux.nu/ports/opt/src/branch/3.7/pkg-get-bashcompletion) as well.
tb closed this issue 2025-01-10 18:46:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ports/opt#16
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?