qt6-webengine won't compile with ninja >= 1.12.0 #5

New Issue

darfo · 2024-04-23T04:16:00+02:00

darfo commented

2024-04-23 04:16:00 +02:00

This error appears compiling qt6-webengine 6.7.0 with ninja 1.12.0:
../../../../../qtwebengine-everywhere-src-6.7.0/src/3rdparty/chromium/content/public/browser/browser_context.h:20:10: fatal error: components/spellcheck/spellcheck_buildflags.h: No such file or directory 20 | #include "components/spellcheck/spellcheck_buildflags.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

https://bugs.gentoo.org/930107 provides the attached patch which corrects the problem for me.

This error appears compiling qt6-webengine 6.7.0 with ninja 1.12.0: `../../../../../qtwebengine-everywhere-src-6.7.0/src/3rdparty/chromium/content/public/browser/browser_context.h:20:10: fatal error: components/spellcheck/spellcheck_buildflags.h: No such file or directory 20 | #include "components/spellcheck/spellcheck_buildflags.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~` [https://bugs.gentoo.org/930107](url) provides the attached patch which corrects the problem for me.

qt6-we-ninja.patch

724 B

tb commented

2024-04-23 21:16:59 +02:00

Thanks for the patch!

The patch works on my desktop, but I have numerous more soft deps installed there.
With the bare minimum in dependencies (as declared) I am hitting some other header that is missing:

In file included from ../../../../../qtwebengine-everywhere-src-6.7.0/src/3rdparty/chromium/components/signin/public/identity_manager/identity_manager.h:21,                                                     
                 from ../../../../../qtwebengine-everywhere-src-6.7.0/src/3rdparty/chromium/components/history/core/browser/web_history_service.cc:23:                                                           
../../../../../qtwebengine-everywhere-src-6.7.0/src/3rdparty/chromium/components/signin/internal/identity_manager/profile_oauth2_token_service.h:19:10: fatal error: components/signin/public/base/signin_buildfl
ags.h: No such file or directory                                                                                                                                                                                 
   19 | #include "components/signin/public/base/signin_buildflags.h"

I have not been able to dig into what else needs to be patched to fix the build.

Thanks for the patch! The patch works on my desktop, but I have numerous more soft deps installed there. With the bare minimum in dependencies (as declared) I am hitting some other header that is missing: ``` In file included from ../../../../../qtwebengine-everywhere-src-6.7.0/src/3rdparty/chromium/components/signin/public/identity_manager/identity_manager.h:21, from ../../../../../qtwebengine-everywhere-src-6.7.0/src/3rdparty/chromium/components/history/core/browser/web_history_service.cc:23: ../../../../../qtwebengine-everywhere-src-6.7.0/src/3rdparty/chromium/components/signin/internal/identity_manager/profile_oauth2_token_service.h:19:10: fatal error: components/signin/public/base/signin_buildfl ags.h: No such file or directory 19 | #include "components/signin/public/base/signin_buildflags.h" ``` I have not been able to dig into what else needs to be patched to fix the build.

tb self-assigned this 2024-05-04 20:09:08 +02:00

tb commented

2024-05-04 20:41:48 +02:00

I'll push an update for qt6-webengine in a bit that contains this fix as well as another patch for ninja 1.12.

tb closed this issue

2024-05-04 20:41:48 +02:00

tb referenced this issue from a commit

2024-05-04 21:29:51 +02:00

qt6-webengine: fixed build issues with ninja 1.12 (e.g. #5), other minor fixes

Sign in to join this conversation.