system/glibc
3
0
Fork 0
Code Issues Projects Releases Wiki Activity

powerpc: fix ifunc-sel.h fix asm constraints and clobber list

Browse Source 
As pointer out on the mailing list, the inline assembly code in
sysdeps/powerpc/ifunc-sel.h doesn't have a list of clobbered registers
and used wrong constraints.

This patch fixes that. I verified it doesn't introduce any change in the
generated code.

Changelog:
	* sysdeps/powerpc/ifunc-sel.h (ifunc_sel): Add "11", "12", "cr0" to the
	clobber list. Use "i" constraint instead of "X".
	(ifunc_one): Add "12" to the clobber list. Use "i" constraint instead
	of "X".
This commit is contained in:
Aurelien Jarno 2016-08-03 00:22:44 +02:00
parent ee71e5b6dd
commit 30f926d3b3
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ChangeLog
View File

@ -2,6 +2,10 @@
* sysdeps/powerpc/ifunc-sel.h (ifunc_sel): Replace beqlr instructions
by beq instructions jumping to the end of the function.
* sysdeps/powerpc/ifunc-sel.h (ifunc_sel): Add "11", "12", "cr0" to the
clobber list. Use "i" constraint instead of "X".
(ifunc_one): Add "12" to the clobber list. Use "i" constraint instead
of "X".
2016-08-02 Joseph Myers <joseph@codesourcery.com>

6
sysdeps/powerpc/ifunc-sel.h
View File

@ -26,7 +26,8 @@ ifunc_sel (int (*f1) (void), int (*f2) (void), int (*f3) (void))
"addi %0,%0,%4-1b@l\n\t"
"2:"
: "=r" (ret)
: "X" (&global), "X" (f1), "X" (f2), "X" (f3));
: "i" (&global), "i" (f1), "i" (f2), "i" (f3)
: "11", "12", "cr0");
return ret;
}
@ -41,7 +42,8 @@ ifunc_one (int (*f1) (void))
"addis %0,%0,%1-1b@ha\n\t"
"addi %0,%0,%1-1b@l"
: "=r" (ret)
: "X" (f1));
: "i" (f1)
: "12");
return ret;
}
#endif