system/glibc
3
0
Fork 0
Code Issues Projects Releases Wiki Activity

Enhance tst-xmmymm.sh to detect zmm register usage in ld.so (BZ #16194)

Browse Source 
2d63a517e4084ec80403cd9f278690fa8b676cc4 added support to save and
restore zmm register in the dynamic linker, but did not enhance
test-xmmymm.sh to detect accidental usage of these registers.  The
patch below adds that check.

The script has also been renamed to tst-ld-sse-use.sh.  To see the
minimal changes, run `git show -M`.

	[BZ #16194]
	* sysdeps/x86/tst-xmmymm.sh: Rename file to...
	* sysdeps/x86/tst-ld-sse-use.sh: ... this.  Check for zmm
	register usage.
	* sysdeps/x86/Makefile: Adjust.
This commit is contained in:
Siddhesh Poyarekar 2014-09-12 12:31:05 +05:30
parent 8c0ab919f6
commit 5379aebddd
3 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
2014-09-12 Siddhesh Poyarekar <siddhesh@redhat.com>
[BZ #16194]
* sysdeps/x86/tst-xmmymm.sh: Rename file to...
* sysdeps/x86/tst-ld-sse-use.sh: ... this. Check for zmm
register usage.
* sysdeps/x86/Makefile: Adjust.
2014-09-11 Kostya Serebryany <konstantin.s.serebryany@gmail.com> 2014-09-11 Kostya Serebryany <konstantin.s.serebryany@gmail.com>
Roland McGrath <roland@hack.frob.com> Roland McGrath <roland@hack.frob.com>

4
sysdeps/x86/Makefile
View File

@ -2,8 +2,8 @@ ifeq ($(subdir),elf)
CFLAGS-.os += $(if $(filter $(@F),$(patsubst %,%.os,$(all-rtld-routines))),\ CFLAGS-.os += $(if $(filter $(@F),$(patsubst %,%.os,$(all-rtld-routines))),\
-mno-sse -mno-mmx) -mno-sse -mno-mmx)
tests-special += $(objpfx)tst-xmmymm.out tests-special += $(objpfx)tst-ld-sse-use.out
$(objpfx)tst-xmmymm.out: ../sysdeps/x86/tst-xmmymm.sh $(objpfx)ld.so $(objpfx)tst-ld-sse-use.out: ../sysdeps/x86/tst-ld-sse-use.sh $(objpfx)ld.so
@echo "Checking ld.so for SSE register use. This will take a few seconds..." @echo "Checking ld.so for SSE register use. This will take a few seconds..."
$(SHELL) $< $(objpfx) '$(NM)' '$(OBJDUMP)' '$(READELF)' > $@; \ $(SHELL) $< $(objpfx) '$(NM)' '$(OBJDUMP)' '$(READELF)' > $@; \
$(evaluate-test) $(evaluate-test)

8
sysdeps/x86/tst-xmmymm.sh → sysdeps/x86/tst-ld-sse-use.sh
View File

@ -1,5 +1,5 @@
#! /bin/bash #! /bin/bash
# Make sure no code in ld.so uses xmm/ymm registers on x86-64. # Make sure no code in ld.so uses xmm/ymm/zmm registers on x86-64.
# Copyright (C) 2009-2014 Free Software Foundation, Inc. # Copyright (C) 2009-2014 Free Software Foundation, Inc.
# This file is part of the GNU C Library. # This file is part of the GNU C Library.
@ -24,7 +24,7 @@ NM="$2"
OBJDUMP="$3" OBJDUMP="$3"
READELF="$4" READELF="$4"
tmp=$(mktemp ${objpfx}tst-xmmymm.XXXXXX) tmp=$(mktemp ${objpfx}tst-ld-sse-use.XXXXXX)
trap 'rm -f "$tmp"' 1 2 3 15 trap 'rm -f "$tmp"' 1 2 3 15
# List of object files we have to test # List of object files we have to test
@ -80,12 +80,12 @@ echo "object files needed: $tocheck"
cp /dev/null "$tmp" cp /dev/null "$tmp"
for f in $tocheck; do for f in $tocheck; do
$OBJDUMP -d "$objpfx"../*/"$f" | $OBJDUMP -d "$objpfx"../*/"$f" |
awk 'BEGIN { last="" } /^[[:xdigit:]]* <[_[:alnum:]]*>:$/ { fct=substr($2, 2, length($2)-3) } /,%[xy]mm[[:digit:]]*$/ { if (last != fct) { print fct; last=fct} }' | awk 'BEGIN { last="" } /^[[:xdigit:]]* <[_[:alnum:]]*>:$/ { fct=substr($2, 2, length($2)-3) } /,%[xyz]mm[[:digit:]]*$/ { if (last != fct) { print fct; last=fct} }' |
while read fct; do while read fct; do
if test "$fct" = "_dl_runtime_profile" -o "$fct" = "_dl_x86_64_restore_sse"; then if test "$fct" = "_dl_runtime_profile" -o "$fct" = "_dl_x86_64_restore_sse"; then
continue; continue;
fi fi
echo "function $fct in $f modifies xmm/ymm" >> "$tmp" echo "function $fct in $f modifies xmm/ymm/zmm" >> "$tmp"
result=1 result=1
done done
done done