support: Report NULL blobs explicitly in TEST_COMPARE
Provide an explicit diagnostic if the length is positive, and do not just crash with a null pointer dereference. Null pointers are only valid if the length is zero, so this can only happen with a faulty test.
This commit is contained in:
parent
11b451c886
commit
85b0e1e8a6
@ -1,3 +1,8 @@
|
||||
2019-05-16 Florian Weimer <fweimer@redhat.com>
|
||||
|
||||
* support/support_test_compare_blob.c (report_blob): Report
|
||||
incorrect NULL blobs.
|
||||
|
||||
2019-05-15 Mark Wielaard <mark@klomp.org>
|
||||
|
||||
[BZ# 24476]
|
||||
|
@ -33,7 +33,9 @@ static void
|
||||
report_blob (const char *what, const unsigned char *blob,
|
||||
unsigned long int length, const char *expr)
|
||||
{
|
||||
if (length > 0)
|
||||
if (blob == NULL && length > 0)
|
||||
printf (" %s (evaluated from %s): NULL\n", what, expr);
|
||||
else if (length > 0)
|
||||
{
|
||||
printf (" %s (evaluated from %s):\n", what, expr);
|
||||
char *quoted = support_quote_blob (blob, length);
|
||||
|
Loading…
x
Reference in New Issue
Block a user