system/glibc
3
0
Fork 0
Code Issues Projects Releases Wiki Activity

Replace "if if " with "if " in comments

Browse Source 
* include/alloc_buffer.h: Replace "if if " with "if " in
	comments.
	* sysdeps/mips/memcpy.S: Likkewise.
	* sysdeps/mips/memset.S: Likewise.
	* sysdeps/x86_64/fpu/multiarch/svml_s_sincosf16_core_avx512.S:
	Likewise.
	* sysdeps/x86_64/fpu/multiarch/svml_s_sincosf4_core_sse4.S:
	Likewise.
	* sysdeps/x86_64/fpu/multiarch/svml_s_sincosf8_core_avx2.S:
	Likewise.
This commit is contained in:
H.J. Lu 2017-10-25 08:05:51 -07:00
parent 9be7530cc0
commit a122dbfb2e
7 changed files with 21 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ChangeLog
View File

@ -1,3 +1,16 @@
2017-10-25 H.J. Lu <hongjiu.lu@intel.com>
* include/alloc_buffer.h: Replace "if if " with "if " in
comments.
* sysdeps/mips/memcpy.S: Likkewise.
* sysdeps/mips/memset.S: Likewise.
* sysdeps/x86_64/fpu/multiarch/svml_s_sincosf16_core_avx512.S:
Likewise.
* sysdeps/x86_64/fpu/multiarch/svml_s_sincosf4_core_sse4.S:
Likewise.
* sysdeps/x86_64/fpu/multiarch/svml_s_sincosf8_core_avx2.S:
Likewise.
2017-10-25 Mike FABIAN <mfabian@redhat.com> 2017-10-25 Mike FABIAN <mfabian@redhat.com>
[BZ #15261] [BZ #15261]

4
include/alloc_buffer.h
View File

@ -267,7 +267,7 @@ __alloc_buffer_alloc (struct alloc_buffer *buf, size_t size, size_t align)
/* Obtain a TYPE * pointer to an object in BUF of TYPE. Consume these /* Obtain a TYPE * pointer to an object in BUF of TYPE. Consume these
bytes from the buffer. Return NULL and mark the buffer as failed bytes from the buffer. Return NULL and mark the buffer as failed
if if there is not enough room in the buffer, or if the buffer has if there is not enough room in the buffer, or if the buffer has
failed before. */ failed before. */
#define alloc_buffer_alloc(buf, type) \ #define alloc_buffer_alloc(buf, type) \
((type *) __alloc_buffer_alloc \ ((type *) __alloc_buffer_alloc \
@ -315,7 +315,7 @@ void * __libc_alloc_buffer_alloc_array (struct alloc_buffer *buf,
/* Obtain a TYPE * pointer to an array of COUNT objects in BUF of /* Obtain a TYPE * pointer to an array of COUNT objects in BUF of
TYPE. Consume these bytes from the buffer. Return NULL and mark TYPE. Consume these bytes from the buffer. Return NULL and mark
the buffer as failed if if there is not enough room in the buffer, the buffer as failed if there is not enough room in the buffer,
or if the buffer has failed before. (Zero-length allocations from or if the buffer has failed before. (Zero-length allocations from
an empty buffer which has not yet failed succeed.) */ an empty buffer which has not yet failed succeed.) */
#define alloc_buffer_alloc_array(buf, type, count) \ #define alloc_buffer_alloc_array(buf, type, count) \

4
sysdeps/mips/memcpy.S
View File

@ -507,7 +507,7 @@ L(skip_pref):
move a2,t8 move a2,t8
/* Here we have src and dest word-aligned but less than 64-bytes or /* Here we have src and dest word-aligned but less than 64-bytes or
* 128 bytes to go. Check for a 32(64) byte chunk and copy if if there * 128 bytes to go. Check for a 32(64) byte chunk and copy if there
* is one. Otherwise jump down to L(chk1w) to handle the tail end of * is one. Otherwise jump down to L(chk1w) to handle the tail end of
* the copy. * the copy.
*/ */
@ -736,7 +736,7 @@ L(ua_skip_pref):
move a2,t8 move a2,t8
/* Here we have src and dest word-aligned but less than 64-bytes or /* Here we have src and dest word-aligned but less than 64-bytes or
* 128 bytes to go. Check for a 32(64) byte chunk and copy if if there * 128 bytes to go. Check for a 32(64) byte chunk and copy if there
* is one. Otherwise jump down to L(ua_chk1w) to handle the tail end of * is one. Otherwise jump down to L(ua_chk1w) to handle the tail end of
* the copy. */ * the copy. */

2
sysdeps/mips/memset.S
View File

@ -370,7 +370,7 @@ L(skip_pref):
move a2,t8 move a2,t8
/* Here we have dest word-aligned but less than 64-bytes or 128 bytes to go. /* Here we have dest word-aligned but less than 64-bytes or 128 bytes to go.
Check for a 32(64) byte chunk and copy if if there is one. Otherwise Check for a 32(64) byte chunk and copy if there is one. Otherwise
jump down to L(chk1w) to handle the tail end of the copy. */ jump down to L(chk1w) to handle the tail end of the copy. */
L(chkw): L(chkw):
andi t8,a2,NSIZEMASK /* is there a 32-byte/64-byte chunk. */ andi t8,a2,NSIZEMASK /* is there a 32-byte/64-byte chunk. */

2
sysdeps/x86_64/fpu/multiarch/svml_s_sincosf16_core_avx512.S
View File

@ -41,7 +41,7 @@
b) Calculate 2 polynomials for sin and cos: b) Calculate 2 polynomials for sin and cos:
RS = X * ( A0 + X^2 * (A1 + x^2 * (A2 + x^2 * (A3)))); RS = X * ( A0 + X^2 * (A1 + x^2 * (A2 + x^2 * (A3))));
RC = B0 + X^2 * (B1 + x^2 * (B2 + x^2 * (B3 + x^2 * (B4)))); RC = B0 + X^2 * (B1 + x^2 * (B2 + x^2 * (B3 + x^2 * (B4))));
c) Swap RS & RC if if first bit of obtained value after c) Swap RS & RC if first bit of obtained value after
Right Shifting is set to 1. Using And, Andnot & Or operations. Right Shifting is set to 1. Using And, Andnot & Or operations.
3) Destination sign setting 3) Destination sign setting
a) Set shifted destination sign using XOR operation: a) Set shifted destination sign using XOR operation:

2
sysdeps/x86_64/fpu/multiarch/svml_s_sincosf4_core_sse4.S
View File

@ -42,7 +42,7 @@ ENTRY (_ZGVbN4vl4l4_sincosf_sse4)
b) Calculate 2 polynomials for sin and cos: b) Calculate 2 polynomials for sin and cos:
RS = X * ( A0 + X^2 * (A1 + x^2 * (A2 + x^2 * (A3)))); RS = X * ( A0 + X^2 * (A1 + x^2 * (A2 + x^2 * (A3))));
RC = B0 + X^2 * (B1 + x^2 * (B2 + x^2 * (B3 + x^2 * (B4)))); RC = B0 + X^2 * (B1 + x^2 * (B2 + x^2 * (B3 + x^2 * (B4))));
c) Swap RS & RC if if first bit of obtained value after c) Swap RS & RC if first bit of obtained value after
Right Shifting is set to 1. Using And, Andnot & Or operations. Right Shifting is set to 1. Using And, Andnot & Or operations.
3) Destination sign setting 3) Destination sign setting
a) Set shifted destination sign using XOR operation: a) Set shifted destination sign using XOR operation:

2
sysdeps/x86_64/fpu/multiarch/svml_s_sincosf8_core_avx2.S
View File

@ -42,7 +42,7 @@ ENTRY (_ZGVdN8vl4l4_sincosf_avx2)
b) Calculate 2 polynomials for sin and cos: b) Calculate 2 polynomials for sin and cos:
RS = X * ( A0 + X^2 * (A1 + x^2 * (A2 + x^2 * (A3)))); RS = X * ( A0 + X^2 * (A1 + x^2 * (A2 + x^2 * (A3))));
RC = B0 + X^2 * (B1 + x^2 * (B2 + x^2 * (B3 + x^2 * (B4)))); RC = B0 + X^2 * (B1 + x^2 * (B2 + x^2 * (B3 + x^2 * (B4))));
c) Swap RS & RC if if first bit of obtained value after c) Swap RS & RC if first bit of obtained value after
Right Shifting is set to 1. Using And, Andnot & Or operations. Right Shifting is set to 1. Using And, Andnot & Or operations.
3) Destination sign setting 3) Destination sign setting
a) Set shifted destination sign using XOR operation: a) Set shifted destination sign using XOR operation: