system/glibc
3
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix sunrpc 64-bit (especially big-endian) issues (bug 14821).

Browse Source
This commit is contained in:
Joseph Myers 2012-11-09 18:21:59 +00:00
parent 554066b83b
commit fb1ae1eede
5 changed files with 66 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ChangeLog
View File

@ -1,3 +1,12 @@
2012-11-09 Joseph Myers <joseph@codesourcery.com>
[BZ #14821]
* sunrpc/clnt_tcp.c (clnttcp_control): Access values at fixed
offset in buffer as u_int32_t not u_long. Consistently use memcpy
for copies of such integer values.
* sunrpc/clnt_udp.c (clntudp_control): Likewise.
* sunrpc/clnt_unix.c (clntunix_control): Likewise.
2012-11-09 Andreas Jaeger <aj@suse.de> 2012-11-09 Andreas Jaeger <aj@suse.de>
* sysdeps/unix/sysv/linux/powerpc/bits/fcntl.h: Remove all * sysdeps/unix/sysv/linux/powerpc/bits/fcntl.h: Remove all

2
NEWS
View File

@ -19,7 +19,7 @@ Version 2.17
14562, 14568, 14576, 14579, 14583, 14587, 14595, 14602, 14610, 14621, 14562, 14568, 14576, 14579, 14583, 14587, 14595, 14602, 14610, 14621,
14638, 14645, 14648, 14652, 14660, 14661, 14669, 14683, 14694, 14716, 14638, 14645, 14648, 14652, 14660, 14661, 14669, 14683, 14694, 14716,
14743, 14767, 14783, 14784, 14785, 14793, 14796, 14797, 14801, 14805, 14743, 14767, 14783, 14784, 14785, 14793, 14796, 14797, 14801, 14805,
14807, 14809, 14811, 14815. 14807, 14809, 14811, 14815, 14821.
* Support for STT_GNU_IFUNC symbols added for s390 and s390x. * Support for STT_GNU_IFUNC symbols added for s390 and s390x.
Optimized versions of memcpy, memset, and memcmp added for System z10 and Optimized versions of memcpy, memset, and memcmp added for System z10 and

41
sunrpc/clnt_tcp.c
View File

@ -364,8 +364,8 @@ static bool_t
clnttcp_control (CLIENT *cl, int request, char *info) clnttcp_control (CLIENT *cl, int request, char *info)
{ {
struct ct_data *ct = (struct ct_data *) cl->cl_private; struct ct_data *ct = (struct ct_data *) cl->cl_private;
u_long *mcall_ptr;
u_long ul; u_long ul;
u_int32_t ui32;
switch (request) switch (request)
@ -395,24 +395,15 @@ clnttcp_control (CLIENT *cl, int request, char *info)
* first element in the call structure *. * first element in the call structure *.
* This will get the xid of the PREVIOUS call * This will get the xid of the PREVIOUS call
*/ */
#if 0 memcpy (&ui32, ct->ct_mcall, sizeof (ui32));
/* This original code has aliasing issues. */ ul = ntohl (ui32);
*(u_long *)info = ntohl (*(u_long *)ct->ct_mcall);
#else
mcall_ptr = (u_long *)ct->ct_mcall;
ul = ntohl (*mcall_ptr);
memcpy (info, &ul, sizeof (ul)); memcpy (info, &ul, sizeof (ul));
#endif
break; break;
case CLSET_XID: case CLSET_XID:
/* This will set the xid of the NEXT call */ /* This will set the xid of the NEXT call */
#if 0 memcpy (&ul, info, sizeof (ul));
/* This original code has aliasing issues. */ ui32 = htonl (ul - 1);
*(u_long *)ct->ct_mcall = htonl (*(u_long *)info - 1); memcpy (ct->ct_mcall, &ui32, sizeof (ui32));
#else
ul = ntohl (*(u_long *)info - 1);
memcpy (ct->ct_mcall, &ul, sizeof (ul));
#endif
/* decrement by 1 as clnttcp_call() increments once */ /* decrement by 1 as clnttcp_call() increments once */
break; break;
case CLGET_VERS: case CLGET_VERS:
@ -422,12 +413,14 @@ clnttcp_control (CLIENT *cl, int request, char *info)
* begining of the RPC header. MUST be changed if the * begining of the RPC header. MUST be changed if the
* call_struct is changed * call_struct is changed
*/ */
*(u_long *)info = ntohl (*(u_long *)(ct->ct_mcall + memcpy (&ui32, ct->ct_mcall + 4 * BYTES_PER_XDR_UNIT, sizeof (ui32));
4 * BYTES_PER_XDR_UNIT)); ul = ntohl (ui32);
memcpy (info, &ul, sizeof (ul));
break; break;
case CLSET_VERS: case CLSET_VERS:
*(u_long *)(ct->ct_mcall + 4 * BYTES_PER_XDR_UNIT) memcpy (&ul, info, sizeof (ul));
= htonl (*(u_long *)info); ui32 = htonl (ul);
memcpy (ct->ct_mcall + 4 * BYTES_PER_XDR_UNIT, &ui32, sizeof (ui32));
break; break;
case CLGET_PROG: case CLGET_PROG:
/* /*
@ -436,12 +429,14 @@ clnttcp_control (CLIENT *cl, int request, char *info)
* begining of the RPC header. MUST be changed if the * begining of the RPC header. MUST be changed if the
* call_struct is changed * call_struct is changed
*/ */
*(u_long *)info = ntohl(*(u_long *)(ct->ct_mcall + memcpy (&ui32, ct->ct_mcall + 3 * BYTES_PER_XDR_UNIT, sizeof (ui32));
3 * BYTES_PER_XDR_UNIT)); ul = ntohl (ui32);
memcpy (info, &ul, sizeof (ul));
break; break;
case CLSET_PROG: case CLSET_PROG:
*(u_long *)(ct->ct_mcall + 3 * BYTES_PER_XDR_UNIT) memcpy (&ul, info, sizeof (ul));
= htonl(*(u_long *)info); ui32 = htonl (ul);
memcpy (ct->ct_mcall + 3 * BYTES_PER_XDR_UNIT, &ui32, sizeof (ui32));
break; break;
/* The following are only possible with TI-RPC */ /* The following are only possible with TI-RPC */
case CLGET_RETRY_TIMEOUT: case CLGET_RETRY_TIMEOUT:

30
sunrpc/clnt_udp.c
View File

@ -547,6 +547,8 @@ static bool_t
clntudp_control (CLIENT *cl, int request, char *info) clntudp_control (CLIENT *cl, int request, char *info)
{ {
struct cu_data *cu = (struct cu_data *) cl->cl_private; struct cu_data *cu = (struct cu_data *) cl->cl_private;
u_long ul;
u_int32_t ui32;
switch (request) switch (request)
{ {
@ -580,11 +582,15 @@ clntudp_control (CLIENT *cl, int request, char *info)
* first element in the call structure *. * first element in the call structure *.
* This will get the xid of the PREVIOUS call * This will get the xid of the PREVIOUS call
*/ */
*(u_long *)info = ntohl(*(u_long *)cu->cu_outbuf); memcpy (&ui32, cu->cu_outbuf, sizeof (ui32));
ul = ntohl (ui32);
memcpy (info, &ul, sizeof (ul));
break; break;
case CLSET_XID: case CLSET_XID:
/* This will set the xid of the NEXT call */ /* This will set the xid of the NEXT call */
*(u_long *)cu->cu_outbuf = htonl(*(u_long *)info - 1); memcpy (&ul, info, sizeof (ul));
ui32 = htonl (ul - 1);
memcpy (cu->cu_outbuf, &ui32, sizeof (ui32));
/* decrement by 1 as clntudp_call() increments once */ /* decrement by 1 as clntudp_call() increments once */
break; break;
case CLGET_VERS: case CLGET_VERS:
@ -594,12 +600,14 @@ clntudp_control (CLIENT *cl, int request, char *info)
* begining of the RPC header. MUST be changed if the * begining of the RPC header. MUST be changed if the
* call_struct is changed * call_struct is changed
*/ */
*(u_long *)info = ntohl(*(u_long *)(cu->cu_outbuf + memcpy (&ui32, cu->cu_outbuf + 4 * BYTES_PER_XDR_UNIT, sizeof (ui32));
4 * BYTES_PER_XDR_UNIT)); ul = ntohl (ui32);
memcpy (info, &ul, sizeof (ul));
break; break;
case CLSET_VERS: case CLSET_VERS:
*(u_long *)(cu->cu_outbuf + 4 * BYTES_PER_XDR_UNIT) memcpy (&ul, info, sizeof (ul));
= htonl(*(u_long *)info); ui32 = htonl (ul);
memcpy (cu->cu_outbuf + 4 * BYTES_PER_XDR_UNIT, &ui32, sizeof (ui32));
break; break;
case CLGET_PROG: case CLGET_PROG:
/* /*
@ -608,12 +616,14 @@ clntudp_control (CLIENT *cl, int request, char *info)
* begining of the RPC header. MUST be changed if the * begining of the RPC header. MUST be changed if the
* call_struct is changed * call_struct is changed
*/ */
*(u_long *)info = ntohl(*(u_long *)(cu->cu_outbuf + memcpy (&ui32, cu->cu_outbuf + 3 * BYTES_PER_XDR_UNIT, sizeof (ui32));
3 * BYTES_PER_XDR_UNIT)); ul = ntohl (ui32);
memcpy (info, &ul, sizeof (ul));
break; break;
case CLSET_PROG: case CLSET_PROG:
*(u_long *)(cu->cu_outbuf + 3 * BYTES_PER_XDR_UNIT) memcpy (&ul, info, sizeof (ul));
= htonl(*(u_long *)info); ui32 = htonl (ul);
memcpy (cu->cu_outbuf + 3 * BYTES_PER_XDR_UNIT, &ui32, sizeof (ui32));
break; break;
/* The following are only possible with TI-RPC */ /* The following are only possible with TI-RPC */
case CLGET_SVC_ADDR: case CLGET_SVC_ADDR:

41
sunrpc/clnt_unix.c
View File

@ -338,8 +338,8 @@ static bool_t
clntunix_control (CLIENT *cl, int request, char *info) clntunix_control (CLIENT *cl, int request, char *info)
{ {
struct ct_data *ct = (struct ct_data *) cl->cl_private; struct ct_data *ct = (struct ct_data *) cl->cl_private;
u_long *mcall_ptr;
u_long ul; u_long ul;
u_int32_t ui32;
switch (request) switch (request)
{ {
@ -367,24 +367,15 @@ clntunix_control (CLIENT *cl, int request, char *info)
* first element in the call structure *. * first element in the call structure *.
* This will get the xid of the PREVIOUS call * This will get the xid of the PREVIOUS call
*/ */
#if 0 memcpy (&ui32, ct->ct_mcall, sizeof (ui32));
/* This original code has aliasing issues. */ ul = ntohl (ui32);
*(u_long *) info = ntohl (*(u_long *)ct->ct_mcall);
#else
mcall_ptr = (u_long *)ct->ct_mcall;
ul = ntohl (*mcall_ptr);
memcpy (info, &ul, sizeof (ul)); memcpy (info, &ul, sizeof (ul));
#endif
break; break;
case CLSET_XID: case CLSET_XID:
/* This will set the xid of the NEXT call */ /* This will set the xid of the NEXT call */
#if 0 memcpy (&ul, info, sizeof (ul));
/* This original code has aliasing issues. */ ui32 = htonl (ul - 1);
*(u_long *) ct->ct_mcall = htonl (*(u_long *)info - 1); memcpy (ct->ct_mcall, &ui32, sizeof (ui32));
#else
ul = ntohl (*(u_long *)info - 1);
memcpy (ct->ct_mcall, &ul, sizeof (ul));
#endif
/* decrement by 1 as clntunix_call() increments once */ /* decrement by 1 as clntunix_call() increments once */
break; break;
case CLGET_VERS: case CLGET_VERS:
@ -394,12 +385,14 @@ clntunix_control (CLIENT *cl, int request, char *info)
* begining of the RPC header. MUST be changed if the * begining of the RPC header. MUST be changed if the
* call_struct is changed * call_struct is changed
*/ */
*(u_long *) info = ntohl (*(u_long *) (ct->ct_mcall memcpy (&ui32, ct->ct_mcall + 4 * BYTES_PER_XDR_UNIT, sizeof (ui32));
+ 4 * BYTES_PER_XDR_UNIT)); ul = ntohl (ui32);
memcpy (info, &ul, sizeof (ul));
break; break;
case CLSET_VERS: case CLSET_VERS:
*(u_long *) (ct->ct_mcall + 4 * BYTES_PER_XDR_UNIT) memcpy (&ul, info, sizeof (ul));
= htonl (*(u_long *) info); ui32 = htonl (ul);
memcpy (ct->ct_mcall + 4 * BYTES_PER_XDR_UNIT, &ui32, sizeof (ui32));
break; break;
case CLGET_PROG: case CLGET_PROG:
/* /*
@ -408,12 +401,14 @@ clntunix_control (CLIENT *cl, int request, char *info)
* begining of the RPC header. MUST be changed if the * begining of the RPC header. MUST be changed if the
* call_struct is changed * call_struct is changed
*/ */
*(u_long *) info = ntohl (*(u_long *) (ct->ct_mcall memcpy (&ui32, ct->ct_mcall + 3 * BYTES_PER_XDR_UNIT, sizeof (ui32));
+ 3 * BYTES_PER_XDR_UNIT)); ul = ntohl (ui32);
memcpy (info, &ul, sizeof (ul));
break; break;
case CLSET_PROG: case CLSET_PROG:
*(u_long *) (ct->ct_mcall + 3 * BYTES_PER_XDR_UNIT) memcpy (&ul, info, sizeof (ul));
= htonl(*(u_long *) info); ui32 = htonl (ul);
memcpy (ct->ct_mcall + 3 * BYTES_PER_XDR_UNIT, &ui32, sizeof (ui32));
break; break;
/* The following are only possible with TI-RPC */ /* The following are only possible with TI-RPC */
case CLGET_RETRY_TIMEOUT: case CLGET_RETRY_TIMEOUT: