2152cf7eda
Although conceptually correct for p{read,write}{64} offset argument passing,
sh4 implementation does not generate the correct expected code. The
__ALIGNMENT_ARG redefinition is incorrect for two reasons: 1. the
kernel-features.h header is included multiple times (since it contains no
guards) and 2. the value it redefines is also incorrect (should be '0, '
instead of empty definition).
This patch fixes it by adding another macro, SYSCALL_LL_PRW{64}, meant to be
used to pass the offset argument on p{read,write}64. It is basically the
already define SYSCALL_LL{64} plus __ALIGNMENT_ARG unless __ASSUME_PRW_DUMMY_ARG
is define. In this case an empty dummy argument is used regardless how
__ALIGNMENT_ARG is defined (sh4 case).
Checked on x86_64, i686, aarch64, armhf, and powerpc64le (basically a sanity
check). Also, John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> and
James Clarke <jrtc27@jrtc27.com> help me check on a debian sh4 bootstrap using
2.24 plus this patch to verify it also corrected fixed the regression issue.
I also verified the generated object for a 2.24 build and master with this
patch for sh4 and both look identical.
* sysdeps/unix/sysv/linux/pread.c (__libc_pread): Use SYSCALL_LL_PRW.
* sysdeps/unix/sysv/linux/pwrite.c (__libc_pwrite): Likewise.
* sysdeps/unix/sysv/linux/pread64.c (__libc_pread64): Use
SYSCALL_LL64_PRW.
* sysdeps/unix/sysv/linux/pwrite64.c (__libc_pwrite64): Likewise.
* sysdeps/unix/sysv/linux/sh/kernel-features.h: Define
__ASSUME_PRW_DUMMY_ARG.
* sysdeps/unix/sysv/linux/sh/pread.c: Remove file.
* sysdeps/unix/sysv/linux/sh/pread64.c: Likewise.
* sysdeps/unix/sysv/linux/sh/pwrite.c: Likewise.
* sysdeps/unix/sysv/linux/sh/pwrite64.c: Likewise.
* sysdeps/unix/sysv/linux/sysdep.h: Define SYSCALL_LL_PRW and
SYSCALL_LL_PRW64 based on __ASSUME_PRW_DUMMY_ARG.
52 lines
1.9 KiB
C
52 lines
1.9 KiB
C
/* Set flags signalling availability of kernel features based on given
|
|
kernel version number. SH version.
|
|
Copyright (C) 1999-2016 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
/* SH uses socketcall. */
|
|
#define __ASSUME_SOCKETCALL 1
|
|
|
|
/* These syscalls were added for SH in 2.6.37. */
|
|
#define __ASSUME_SOCKET_SYSCALL 1
|
|
#define __ASSUME_BIND_SYSCALL 1
|
|
#define __ASSUME_CONNECT_SYSCALL 1
|
|
#define __ASSUME_LISTEN_SYSCALL 1
|
|
#define __ASSUME_ACCEPT_SYSCALL 1
|
|
#define __ASSUME_GETSOCKNAME_SYSCALL 1
|
|
#define __ASSUME_GETPEERNAME_SYSCALL 1
|
|
#define __ASSUME_SOCKETPAIR_SYSCALL 1
|
|
#define __ASSUME_SEND_SYSCALL 1
|
|
#define __ASSUME_SENDTO_SYSCALL 1
|
|
#define __ASSUME_RECV_SYSCALL 1
|
|
#define __ASSUME_RECVFROM_SYSCALL 1
|
|
#define __ASSUME_SHUTDOWN_SYSCALL 1
|
|
#define __ASSUME_GETSOCKOPT_SYSCALL 1
|
|
#define __ASSUME_SETSOCKOPT_SYSCALL 1
|
|
|
|
/* The sendmmsg syscall was added for SH in 3.0. */
|
|
#define __ASSUME_SENDMMSG_SYSCALL_WITH_SOCKETCALL 1
|
|
|
|
#include_next <kernel-features.h>
|
|
|
|
/* SH does not have a 64-bit inode field. */
|
|
#undef __ASSUME_ST_INO_64_BIT
|
|
|
|
/* SH4 ABI does not really require argument alignment for 64-bits, but
|
|
the kernel interface for p{read,write}64 adds a dummy long argument
|
|
before the offset. */
|
|
#define __ASSUME_PRW_DUMMY_ARG 1
|