Joseph Myers
32db86d558
Add fall-through comments.
...
This patch adds fall-through comments in some cases where -Wextra
produces implicit-fallthrough warnings.
The patch is non-exhaustive. Apart from architecture-specific code
for non-x86_64 architectures, it does not change sunrpc/xdr.c (legacy
code, probably should have such changes, but left to be dealt with
separately), or places that already had comments about the
fall-through but not matching the form expected by
-Wimplicit-fallthrough=3 (the default level with -Wextra; my
inclination is to adjust those comments to match rather than
downgrading to -Wimplicit-fallthrough=1 to allow any comment), or one
place where I thought the implicit fallthrough was not correct and so
should be handled separately as a bug fix. I think the key thing to
consider in review of this patch is whether the fall-through is indeed
intended and correct in each place where such a comment is added.
Tested for x86_64.
* elf/dl-exception.c (_dl_exception_create_format): Add
fall-through comments.
* elf/ldconfig.c (parse_conf_include): Likewise.
* elf/rtld.c (print_statistics): Likewise.
* locale/programs/charmap.c (parse_charmap): Likewise.
* misc/mntent_r.c (__getmntent_r): Likewise.
* posix/wordexp.c (parse_arith): Likewise.
(parse_backtick): Likewise.
* resolv/ns_ttl.c (ns_parse_ttl): Likewise.
* sysdeps/x86/cpu-features.c (init_cpu_features): Likewise.
* sysdeps/x86_64/dl-machine.h (elf_machine_rela): Likewise.
2019-02-12 10:30:34 +00:00
..
2019-02-08 16:51:17 +01:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2018-07-18 21:04:12 +00:00
2018-07-18 21:04:12 +00:00
2018-07-18 21:04:12 +00:00
2018-07-18 21:04:12 +00:00
2018-07-18 21:04:12 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2018-02-27 16:58:44 +01:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-02-04 15:45:02 +01:00
2019-02-04 15:45:02 +01:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:15:13 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-02-08 11:27:55 +01:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2018-07-04 09:54:45 -03:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-31 13:18:56 -08:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-02-04 14:37:05 +01:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-02-04 15:45:02 +01:00
2019-02-04 15:45:02 +01:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2017-02-16 17:33:18 -05:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2017-04-07 07:51:52 -04:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2018-10-17 09:34:13 +02:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2018-03-03 17:44:24 +01:00
2018-03-03 17:44:24 +01:00
2018-03-03 17:44:24 +01:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-02-01 11:03:35 +01:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-02-08 11:27:55 +01:00
2018-12-07 16:04:05 +01:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-01-01 00:11:28 +00:00
2019-02-12 10:30:34 +00:00
2019-01-01 00:11:28 +00:00